mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-07 11:56:37 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
195 lines
6.2 KiB
Python
195 lines
6.2 KiB
Python
from __future__ import annotations
|
|
|
|
import os
|
|
import tempfile
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, Mock
|
|
|
|
import pytest
|
|
|
|
from langbot.pkg.api.http.context import ExecutionContext
|
|
from langbot.pkg.box.workspace import (
|
|
BoxWorkspaceSession,
|
|
classify_python_workspace,
|
|
infer_workspace_host_path,
|
|
rewrite_mounted_path,
|
|
wrap_python_command_with_env,
|
|
)
|
|
|
|
|
|
_CONTEXT = ExecutionContext(
|
|
instance_uuid='instance-a',
|
|
workspace_uuid='workspace-a',
|
|
placement_generation=1,
|
|
)
|
|
|
|
|
|
def test_rewrite_mounted_path_translates_host_prefix():
|
|
result = rewrite_mounted_path('/tmp/demo/project/app.py', '/tmp/demo/project')
|
|
assert result == '/workspace/app.py'
|
|
|
|
|
|
def test_infer_workspace_host_path_unwraps_virtualenv_bin_dir():
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
project_root = os.path.join(tmpdir, 'project')
|
|
os.makedirs(os.path.join(project_root, '.venv', 'bin'))
|
|
python_bin = os.path.join(project_root, '.venv', 'bin', 'python')
|
|
script = os.path.join(project_root, 'server.py')
|
|
|
|
with open(python_bin, 'w', encoding='utf-8') as handle:
|
|
handle.write('')
|
|
with open(script, 'w', encoding='utf-8') as handle:
|
|
handle.write('print("ok")\n')
|
|
|
|
result = infer_workspace_host_path(python_bin, [script])
|
|
|
|
assert result == os.path.realpath(project_root)
|
|
|
|
|
|
def test_classify_python_workspace_detects_package_and_requirements():
|
|
with tempfile.TemporaryDirectory() as tmpdir:
|
|
assert classify_python_workspace(tmpdir) is None
|
|
|
|
with open(os.path.join(tmpdir, 'requirements.txt'), 'w', encoding='utf-8') as handle:
|
|
handle.write('requests\n')
|
|
assert classify_python_workspace(tmpdir) == 'requirements'
|
|
|
|
with open(os.path.join(tmpdir, 'pyproject.toml'), 'w', encoding='utf-8') as handle:
|
|
handle.write('[project]\nname = "demo"\n')
|
|
assert classify_python_workspace(tmpdir) == 'package'
|
|
|
|
|
|
def test_wrap_python_command_with_env_contains_bootstrap_and_command():
|
|
command = wrap_python_command_with_env('python script.py')
|
|
|
|
assert '_LB_SYSTEM_PYTHON="$(command -v python3 || command -v python || true)"' in command
|
|
assert '"$_LB_SYSTEM_PYTHON" -m venv "$_LB_VENV_DIR"' in command
|
|
assert 'kill -0 "$_LB_LOCK_OWNER"' in command
|
|
assert 'max_manifest_bytes = 10 * 1024 * 1024' in command
|
|
assert 'handle.read(1024 * 1024)' in command
|
|
assert 'digest.update(handle.read())' not in command
|
|
assert 'export VIRTUAL_ENV="$_LB_VENV_DIR"' in command
|
|
assert command.rstrip().endswith('python script.py')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_workspace_session_execute_for_query_uses_session_payload():
|
|
box_service = SimpleNamespace(execute_spec_payload=AsyncMock(return_value={'ok': True}))
|
|
workspace = BoxWorkspaceSession(
|
|
box_service,
|
|
_CONTEXT,
|
|
'skill-person_123-demo',
|
|
host_path='/tmp/project',
|
|
host_path_mode='rw',
|
|
env={'FOO': 'bar'},
|
|
)
|
|
|
|
query = SimpleNamespace(query_id='q1')
|
|
result = await workspace.execute_for_query(query, 'python run.py', workdir='/workspace', timeout_sec=30)
|
|
|
|
assert result == {'ok': True}
|
|
payload = box_service.execute_spec_payload.await_args.args[0]
|
|
assert payload == {
|
|
'session_id': 'skill-person_123-demo',
|
|
'workdir': '/workspace',
|
|
'env': {'FOO': 'bar'},
|
|
'persistent': False,
|
|
'host_path': '/tmp/project',
|
|
'host_path_mode': 'rw',
|
|
'cmd': 'python run.py',
|
|
'timeout_sec': 30,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_workspace_session_start_managed_process_rewrites_command_and_args():
|
|
box_service = SimpleNamespace(start_managed_process=AsyncMock(return_value={'status': 'running'}))
|
|
workspace = BoxWorkspaceSession(
|
|
box_service,
|
|
_CONTEXT,
|
|
'mcp-u1',
|
|
host_path='/tmp/project',
|
|
host_path_mode='ro',
|
|
)
|
|
|
|
result = await workspace.start_managed_process(
|
|
'/tmp/project/.venv/bin/python',
|
|
['/tmp/project/server.py', '--config', '/tmp/project/config.json'],
|
|
env={'TOKEN': '1'},
|
|
)
|
|
|
|
assert result == {'status': 'running'}
|
|
execution_context = box_service.start_managed_process.await_args.args[0]
|
|
session_id = box_service.start_managed_process.await_args.args[1]
|
|
payload = box_service.start_managed_process.await_args.args[2]
|
|
assert execution_context == _CONTEXT
|
|
assert session_id == 'mcp-u1'
|
|
assert payload == {
|
|
'command': 'python',
|
|
'args': ['/workspace/server.py', '--config', '/workspace/config.json'],
|
|
'env': {'TOKEN': '1'},
|
|
'cwd': '/workspace',
|
|
'process_id': 'default',
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_workspace_session_relay_connection_keeps_execution_context():
|
|
box_service = SimpleNamespace(
|
|
get_managed_process_websocket_connection=AsyncMock(
|
|
return_value=(
|
|
'ws://box/relay',
|
|
{'X-LangBot-Placement-Generation': '1'},
|
|
)
|
|
)
|
|
)
|
|
workspace = BoxWorkspaceSession(
|
|
box_service,
|
|
_CONTEXT,
|
|
'mcp-shared',
|
|
)
|
|
|
|
connection = await workspace.get_managed_process_websocket_connection('server-a')
|
|
|
|
assert connection == (
|
|
'ws://box/relay',
|
|
{'X-LangBot-Placement-Generation': '1'},
|
|
)
|
|
box_service.get_managed_process_websocket_connection.assert_awaited_once_with(
|
|
_CONTEXT,
|
|
'mcp-shared',
|
|
'server-a',
|
|
)
|
|
|
|
|
|
def test_workspace_session_build_session_payload_keeps_generic_workspace_shape():
|
|
workspace = BoxWorkspaceSession(
|
|
Mock(),
|
|
_CONTEXT,
|
|
'workspace-1',
|
|
host_path='/tmp/project',
|
|
host_path_mode='rw',
|
|
env={'FOO': 'bar'},
|
|
network='on',
|
|
read_only_rootfs=False,
|
|
image='python:3.11',
|
|
cpus=1.0,
|
|
memory_mb=512,
|
|
pids_limit=128,
|
|
)
|
|
|
|
assert workspace.build_session_payload() == {
|
|
'session_id': 'workspace-1',
|
|
'workdir': '/workspace',
|
|
'env': {'FOO': 'bar'},
|
|
'persistent': False,
|
|
'network': 'on',
|
|
'read_only_rootfs': False,
|
|
'host_path': '/tmp/project',
|
|
'host_path_mode': 'rw',
|
|
'image': 'python:3.11',
|
|
'cpus': 1.0,
|
|
'memory_mb': 512,
|
|
'pids_limit': 128,
|
|
}
|