mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 04:10:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
297 lines
9.7 KiB
Python
297 lines
9.7 KiB
Python
"""
|
|
RuntimeBot.resolve_pipeline_uuid and _match_operator unit tests
|
|
"""
|
|
|
|
from unittest.mock import Mock
|
|
|
|
|
|
class TestMatchOperator:
|
|
"""Test the _match_operator static method."""
|
|
|
|
@staticmethod
|
|
def _get_class():
|
|
from langbot.pkg.platform.botmgr import RuntimeBot
|
|
|
|
return RuntimeBot
|
|
|
|
def test_eq(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello', 'eq', 'hello') is True
|
|
assert cls._match_operator('hello', 'eq', 'world') is False
|
|
|
|
def test_neq(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello', 'neq', 'world') is True
|
|
assert cls._match_operator('hello', 'neq', 'hello') is False
|
|
|
|
def test_contains(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello world', 'contains', 'world') is True
|
|
assert cls._match_operator('hello world', 'contains', 'xyz') is False
|
|
|
|
def test_not_contains(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello world', 'not_contains', 'xyz') is True
|
|
assert cls._match_operator('hello world', 'not_contains', 'world') is False
|
|
|
|
def test_starts_with(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello world', 'starts_with', 'hello') is True
|
|
assert cls._match_operator('hello world', 'starts_with', 'world') is False
|
|
|
|
def test_regex(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello123', 'regex', r'\d+') is True
|
|
assert cls._match_operator('hello', 'regex', r'\d+') is False
|
|
|
|
def test_regex_invalid_pattern(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello', 'regex', r'[invalid') is False
|
|
|
|
def test_unknown_operator(self):
|
|
cls = self._get_class()
|
|
assert cls._match_operator('hello', 'unknown_op', 'hello') is False
|
|
|
|
|
|
class TestResolvePipelineUuid:
|
|
"""Test the resolve_pipeline_uuid method."""
|
|
|
|
@staticmethod
|
|
def _make_bot(default_pipeline: str, rules: list):
|
|
from langbot.pkg.platform.botmgr import RuntimeBot
|
|
|
|
bot_entity = Mock()
|
|
bot_entity.use_pipeline_uuid = default_pipeline
|
|
bot_entity.pipeline_routing_rules = rules
|
|
|
|
bot = object.__new__(RuntimeBot)
|
|
bot.bot_entity = bot_entity
|
|
return bot
|
|
|
|
def test_no_rules_returns_default(self):
|
|
bot = self._make_bot('default-uuid', [])
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_none_rules_returns_default(self):
|
|
bot = self._make_bot('default-uuid', None)
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_launcher_type_match(self):
|
|
rules = [
|
|
{
|
|
'type': 'launcher_type',
|
|
'operator': 'eq',
|
|
'value': 'group',
|
|
'pipeline_uuid': 'group-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('group', '123', 'hi')
|
|
assert uuid == 'group-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_launcher_id_match(self):
|
|
rules = [
|
|
{
|
|
'type': 'launcher_id',
|
|
'operator': 'eq',
|
|
'value': '12345',
|
|
'pipeline_uuid': 'vip-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '12345', 'hi')
|
|
assert uuid == 'vip-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '99999', 'hi')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_message_content_contains(self):
|
|
rules = [
|
|
{
|
|
'type': 'message_content',
|
|
'operator': 'contains',
|
|
'value': '紧急',
|
|
'pipeline_uuid': 'urgent-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', '这是紧急消息')
|
|
assert uuid == 'urgent-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', '普通消息')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_message_content_regex(self):
|
|
rules = [
|
|
{
|
|
'type': 'message_content',
|
|
'operator': 'regex',
|
|
'value': r'^/admin\b',
|
|
'pipeline_uuid': 'admin-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', '/admin help')
|
|
assert uuid == 'admin-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hello /admin')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_message_has_element_eq(self):
|
|
rules = [
|
|
{
|
|
'type': 'message_has_element',
|
|
'operator': 'eq',
|
|
'value': 'Image',
|
|
'pipeline_uuid': 'image-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi', ['Plain', 'Image'])
|
|
assert uuid == 'image-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi', ['Plain'])
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_message_has_element_neq(self):
|
|
rules = [
|
|
{
|
|
'type': 'message_has_element',
|
|
'operator': 'neq',
|
|
'value': 'Image',
|
|
'pipeline_uuid': 'text-only-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi', ['Plain'])
|
|
assert uuid == 'text-only-pipeline'
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi', ['Plain', 'Image'])
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_message_has_element_no_types_provided(self):
|
|
"""When element types are not provided, should not match."""
|
|
rules = [
|
|
{
|
|
'type': 'message_has_element',
|
|
'operator': 'eq',
|
|
'value': 'Image',
|
|
'pipeline_uuid': 'image-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_first_match_wins(self):
|
|
rules = [
|
|
{
|
|
'type': 'launcher_type',
|
|
'operator': 'eq',
|
|
'value': 'group',
|
|
'pipeline_uuid': 'first-pipeline',
|
|
},
|
|
{
|
|
'type': 'launcher_type',
|
|
'operator': 'eq',
|
|
'value': 'group',
|
|
'pipeline_uuid': 'second-pipeline',
|
|
},
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('group', '123', 'hi')
|
|
assert uuid == 'first-pipeline'
|
|
assert routed is True
|
|
|
|
def test_skip_invalid_rules(self):
|
|
rules = [
|
|
{'type': '', 'operator': 'eq', 'value': 'x', 'pipeline_uuid': 'p1'},
|
|
{'type': 'launcher_type', 'operator': 'eq', 'value': 'person', 'pipeline_uuid': ''},
|
|
{'type': 'launcher_type', 'operator': 'eq', 'value': 'person', 'pipeline_uuid': 'valid'},
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'valid'
|
|
assert routed is True
|
|
|
|
def test_default_operator_is_eq(self):
|
|
rules = [
|
|
{
|
|
'type': 'launcher_type',
|
|
'value': 'person',
|
|
'pipeline_uuid': 'person-pipeline',
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'hi')
|
|
assert uuid == 'person-pipeline'
|
|
assert routed is True
|
|
|
|
def test_discard_pipeline(self):
|
|
"""When pipeline_uuid is __discard__, the message should be discarded."""
|
|
from langbot.pkg.platform.botmgr import RuntimeBot
|
|
|
|
rules = [
|
|
{
|
|
'type': 'message_content',
|
|
'operator': 'contains',
|
|
'value': 'spam',
|
|
'pipeline_uuid': RuntimeBot.PIPELINE_DISCARD,
|
|
}
|
|
]
|
|
bot = self._make_bot('default-uuid', rules)
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'this is spam')
|
|
assert uuid == RuntimeBot.PIPELINE_DISCARD
|
|
assert routed is True
|
|
|
|
uuid, routed = bot.resolve_pipeline_uuid('person', '123', 'normal message')
|
|
assert uuid == 'default-uuid'
|
|
assert routed is False
|
|
|
|
def test_websocket_task_override_does_not_mutate_bot_default(self):
|
|
bot = self._make_bot('default-uuid', [])
|
|
adapter = Mock()
|
|
adapter.get_pipeline_uuid_override.return_value = 'connection-pipeline'
|
|
|
|
pipeline_uuid, routed = bot.resolve_event_pipeline_uuid(
|
|
adapter,
|
|
'person',
|
|
'launcher',
|
|
'hello',
|
|
)
|
|
|
|
assert pipeline_uuid == 'connection-pipeline'
|
|
assert routed is False
|
|
assert bot.bot_entity.use_pipeline_uuid == 'default-uuid'
|