mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-07 11:56:37 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
166 lines
5.8 KiB
Python
166 lines
5.8 KiB
Python
"""Tests for PluginRuntimeConnector pure logic methods.
|
|
|
|
Tests methods that don't require real plugin runtime processes:
|
|
- _inspect_plugin_package: identity and deps extraction from zip files
|
|
- _parse_plugin_id: plugin ID string parsing
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import io
|
|
import zipfile
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
|
|
class TestExtractDepsMetadata:
|
|
"""Tests for dependency metadata extraction from plugin packages."""
|
|
|
|
def _create_connector(self):
|
|
"""Create a connector instance for testing."""
|
|
from langbot.pkg.plugin.connector import PluginRuntimeConnector
|
|
|
|
mock_app = MagicMock()
|
|
mock_app.instance_config.data.get.return_value = {'enable': True}
|
|
mock_app.logger = MagicMock()
|
|
|
|
connector = PluginRuntimeConnector(mock_app, MagicMock())
|
|
return connector
|
|
|
|
def test_extract_deps_with_requirements_txt(self):
|
|
"""Extract dependency count from requirements.txt in plugin zip."""
|
|
connector = self._create_connector()
|
|
|
|
# Create a mock zip file with requirements.txt
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w') as zf:
|
|
zf.writestr('requirements.txt', 'requests>=2.0\nflask\n# comment\n\nnumpy')
|
|
|
|
zip_bytes = zip_buffer.getvalue()
|
|
|
|
task_context = SimpleNamespace(metadata={})
|
|
connector._inspect_plugin_package(zip_bytes, task_context)
|
|
|
|
assert task_context.metadata['deps_total'] == 3 # requests>=2.0, flask, numpy
|
|
# deps_list contains full requirement lines including version specifiers
|
|
assert 'requests>=2.0' in task_context.metadata['deps_list']
|
|
assert 'flask' in task_context.metadata['deps_list']
|
|
assert 'numpy' in task_context.metadata['deps_list']
|
|
|
|
def test_extract_deps_empty_requirements(self):
|
|
"""Handle empty requirements.txt."""
|
|
connector = self._create_connector()
|
|
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w') as zf:
|
|
zf.writestr('requirements.txt', '# only comments\n\n')
|
|
|
|
zip_bytes = zip_buffer.getvalue()
|
|
|
|
task_context = SimpleNamespace(metadata={})
|
|
connector._inspect_plugin_package(zip_bytes, task_context)
|
|
|
|
assert task_context.metadata['deps_total'] == 0
|
|
assert task_context.metadata['deps_list'] == []
|
|
|
|
def test_extract_deps_no_requirements_txt(self):
|
|
"""Handle zip without requirements.txt."""
|
|
connector = self._create_connector()
|
|
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w') as zf:
|
|
zf.writestr('plugin.py', 'print("hello")')
|
|
|
|
zip_bytes = zip_buffer.getvalue()
|
|
|
|
task_context = SimpleNamespace(metadata={})
|
|
connector._inspect_plugin_package(zip_bytes, task_context)
|
|
|
|
# No requirements.txt found, metadata unchanged
|
|
assert 'deps_total' not in task_context.metadata
|
|
|
|
def test_extract_deps_none_task_context(self):
|
|
"""Handle None task_context gracefully."""
|
|
connector = self._create_connector()
|
|
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w') as zf:
|
|
zf.writestr('requirements.txt', 'requests')
|
|
|
|
zip_bytes = zip_buffer.getvalue()
|
|
|
|
# Should return early without error
|
|
connector._inspect_plugin_package(zip_bytes, None)
|
|
|
|
def test_extract_deps_invalid_zip(self):
|
|
"""Handle invalid zip file gracefully."""
|
|
connector = self._create_connector()
|
|
|
|
# Not a valid zip
|
|
invalid_bytes = b'not a zip file'
|
|
|
|
task_context = SimpleNamespace(metadata={})
|
|
connector._inspect_plugin_package(invalid_bytes, task_context)
|
|
|
|
# Should catch exception and pass silently
|
|
assert 'deps_total' not in task_context.metadata
|
|
|
|
def test_extract_deps_nested_requirements(self):
|
|
"""Handle requirements.txt in nested directory."""
|
|
connector = self._create_connector()
|
|
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w') as zf:
|
|
zf.writestr('subdir/requirements.txt', 'pytest\nblack')
|
|
|
|
zip_bytes = zip_buffer.getvalue()
|
|
|
|
task_context = SimpleNamespace(metadata={})
|
|
connector._inspect_plugin_package(zip_bytes, task_context)
|
|
|
|
# Should find requirements.txt in subdirectory
|
|
assert task_context.metadata['deps_total'] == 2
|
|
|
|
def test_archive_preview_rejects_extreme_compression_ratio(self):
|
|
from langbot.pkg.plugin.connector import inspect_plugin_archive_metadata
|
|
|
|
zip_buffer = io.BytesIO()
|
|
with zipfile.ZipFile(zip_buffer, 'w', compression=zipfile.ZIP_DEFLATED) as zf:
|
|
zf.writestr('manifest.yaml', 'kind: Plugin\nmetadata: {}\n')
|
|
zf.writestr('bomb.py', b'A' * (1024 * 1024))
|
|
|
|
with pytest.raises(ValueError, match='compression-ratio limit'):
|
|
inspect_plugin_archive_metadata(zip_buffer.getvalue())
|
|
|
|
|
|
class TestParsePluginId:
|
|
"""Tests for _parse_plugin_id static method."""
|
|
|
|
def test_parse_valid_plugin_id(self):
|
|
"""Parse valid plugin ID format 'author/name'."""
|
|
from langbot.pkg.plugin.connector import PluginRuntimeConnector
|
|
|
|
author, name = PluginRuntimeConnector._parse_plugin_id('myauthor/myplugin')
|
|
assert author == 'myauthor'
|
|
assert name == 'myplugin'
|
|
|
|
def test_parse_plugin_id_empty(self):
|
|
"""Empty plugin ID is invalid."""
|
|
from langbot.pkg.plugin.connector import PluginRuntimeConnector
|
|
|
|
with pytest.raises(ValueError):
|
|
PluginRuntimeConnector._parse_plugin_id('')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_marketplace_response_reader_is_bounded():
|
|
from langbot.pkg.plugin.connector import _read_httpx_response_limited
|
|
|
|
response = httpx.Response(200, content=b'oversized')
|
|
|
|
with pytest.raises(ValueError, match='exceeds'):
|
|
await _read_httpx_response_limited(response, max_bytes=4)
|