mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-05 11:06:07 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
223 lines
6.9 KiB
Python
223 lines
6.9 KiB
Python
"""Tests for VectorDatabase base class and SearchType enum."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from unittest.mock import AsyncMock
|
|
import pytest
|
|
|
|
from langbot.pkg.vector.vdb import (
|
|
SearchType,
|
|
VectorDatabase,
|
|
remember_bounded_mapping,
|
|
remember_bounded_set,
|
|
)
|
|
|
|
|
|
class TestSearchType:
|
|
"""Tests for SearchType enum."""
|
|
|
|
def test_search_type_values(self):
|
|
"""Test SearchType enum values."""
|
|
assert SearchType.VECTOR.value == 'vector'
|
|
assert SearchType.FULL_TEXT.value == 'full_text'
|
|
assert SearchType.HYBRID.value == 'hybrid'
|
|
|
|
def test_search_type_is_string_enum(self):
|
|
"""SearchType is a string enum."""
|
|
assert isinstance(SearchType.VECTOR, str)
|
|
assert SearchType.VECTOR == 'vector'
|
|
|
|
def test_search_type_from_string(self):
|
|
"""Can create SearchType from string."""
|
|
assert SearchType('vector') == SearchType.VECTOR
|
|
assert SearchType('full_text') == SearchType.FULL_TEXT
|
|
assert SearchType('hybrid') == SearchType.HYBRID
|
|
|
|
|
|
def test_runtime_cache_helpers_bound_mapping_and_set():
|
|
mapping = {}
|
|
values = set()
|
|
|
|
for index in range(100):
|
|
remember_bounded_mapping(mapping, str(index), object(), 8)
|
|
remember_bounded_set(values, str(index), 8)
|
|
|
|
assert len(mapping) == 8
|
|
assert len(values) == 8
|
|
|
|
|
|
class TestVectorDatabaseAbstractMethods:
|
|
"""Tests for VectorDatabase abstract methods."""
|
|
|
|
def test_vector_database_is_abstract(self):
|
|
"""VectorDatabase is abstract and cannot be instantiated directly."""
|
|
with pytest.raises(TypeError):
|
|
VectorDatabase()
|
|
|
|
def test_abstract_methods_required(self):
|
|
"""Subclass must implement all abstract methods."""
|
|
|
|
class IncompleteVectorDB(VectorDatabase):
|
|
pass
|
|
|
|
with pytest.raises(TypeError):
|
|
IncompleteVectorDB()
|
|
|
|
def test_supported_search_types_default(self):
|
|
"""Default supported_search_types returns [VECTOR]."""
|
|
|
|
class MinimalVectorDB(VectorDatabase):
|
|
async def add_embeddings(self, collection, ids, embeddings_list, metadatas, documents=None):
|
|
pass
|
|
|
|
async def search(
|
|
self,
|
|
collection,
|
|
query_embedding,
|
|
k=5,
|
|
search_type='vector',
|
|
query_text='',
|
|
filter=None,
|
|
vector_weight=None,
|
|
):
|
|
pass
|
|
|
|
async def delete_by_file_id(self, collection, file_id):
|
|
pass
|
|
|
|
async def delete_by_filter(self, collection, filter):
|
|
pass
|
|
|
|
async def get_or_create_collection(self, collection):
|
|
pass
|
|
|
|
async def delete_collection(self, collection):
|
|
pass
|
|
|
|
db = MinimalVectorDB()
|
|
assert db.supported_search_types() == [SearchType.VECTOR]
|
|
|
|
def test_list_by_filter_default_implementation(self):
|
|
"""list_by_filter has default implementation returning empty."""
|
|
|
|
class MinimalVectorDB(VectorDatabase):
|
|
async def add_embeddings(self, collection, ids, embeddings_list, metadatas, documents=None):
|
|
pass
|
|
|
|
async def search(
|
|
self,
|
|
collection,
|
|
query_embedding,
|
|
k=5,
|
|
search_type='vector',
|
|
query_text='',
|
|
filter=None,
|
|
vector_weight=None,
|
|
):
|
|
pass
|
|
|
|
async def delete_by_file_id(self, collection, file_id):
|
|
pass
|
|
|
|
async def delete_by_filter(self, collection, filter):
|
|
pass
|
|
|
|
async def get_or_create_collection(self, collection):
|
|
pass
|
|
|
|
async def delete_collection(self, collection):
|
|
pass
|
|
|
|
db = MinimalVectorDB()
|
|
# list_by_filter should return empty list and -1 for total
|
|
import asyncio
|
|
|
|
result = asyncio.get_event_loop().run_until_complete(db.list_by_filter('test_collection'))
|
|
assert result == ([], -1)
|
|
|
|
|
|
class TestVectorDatabaseInterface:
|
|
"""Tests for VectorDatabase interface contracts."""
|
|
|
|
@pytest.fixture
|
|
def mock_vector_db(self):
|
|
"""Create a minimal mock VectorDatabase for testing."""
|
|
|
|
class MockVectorDB(VectorDatabase):
|
|
def __init__(self):
|
|
self.add_embeddings = AsyncMock()
|
|
self.search = AsyncMock(
|
|
return_value={
|
|
'ids': [['id1', 'id2']],
|
|
'distances': [[0.1, 0.2]],
|
|
'metadatas': [[{'key': 'val1'}, {'key': 'val2'}]],
|
|
}
|
|
)
|
|
self.delete_by_file_id = AsyncMock()
|
|
self.delete_by_filter = AsyncMock(return_value=5)
|
|
self.get_or_create_collection = AsyncMock()
|
|
self.delete_collection = AsyncMock()
|
|
|
|
async def add_embeddings(self, collection, ids, embeddings_list, metadatas, documents=None):
|
|
pass
|
|
|
|
async def search(
|
|
self,
|
|
collection,
|
|
query_embedding,
|
|
k=5,
|
|
search_type='vector',
|
|
query_text='',
|
|
filter=None,
|
|
vector_weight=None,
|
|
):
|
|
pass
|
|
|
|
async def delete_by_file_id(self, collection, file_id):
|
|
pass
|
|
|
|
async def delete_by_filter(self, collection, filter):
|
|
pass
|
|
|
|
async def get_or_create_collection(self, collection):
|
|
pass
|
|
|
|
async def delete_collection(self, collection):
|
|
pass
|
|
|
|
return MockVectorDB()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_add_embeddings_signature(self, mock_vector_db):
|
|
"""add_embeddings has expected signature."""
|
|
await mock_vector_db.add_embeddings(
|
|
collection='test',
|
|
ids=['id1', 'id2'],
|
|
embeddings_list=[[0.1, 0.2], [0.3, 0.4]],
|
|
metadatas=[{'a': 1}, {'b': 2}],
|
|
documents=['doc1', 'doc2'],
|
|
)
|
|
mock_vector_db.add_embeddings.assert_called_once()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_search_signature(self, mock_vector_db):
|
|
"""search has expected signature with all optional params."""
|
|
import numpy as np
|
|
|
|
await mock_vector_db.search(
|
|
collection='test',
|
|
query_embedding=np.array([0.1, 0.2]),
|
|
k=10,
|
|
search_type='hybrid',
|
|
query_text='search text',
|
|
filter={'file_id': 'abc'},
|
|
vector_weight=0.7,
|
|
)
|
|
mock_vector_db.search.assert_called_once()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_delete_by_filter_returns_int(self, mock_vector_db):
|
|
"""delete_by_filter returns int count."""
|
|
result = await mock_vector_db.delete_by_filter('test', {'file_id': 'abc'})
|
|
assert isinstance(result, int)
|