mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-04 02:26:07 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
304 lines
11 KiB
Python
304 lines
11 KiB
Python
"""
|
|
API integration tests for bot endpoints.
|
|
|
|
Tests real HTTP API behavior for bot management.
|
|
|
|
Run: uv run pytest tests/integration/api/test_bots.py -q
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from unittest.mock import MagicMock, AsyncMock, Mock
|
|
from types import SimpleNamespace
|
|
|
|
from tests.factories import FakeApp
|
|
|
|
|
|
pytestmark = pytest.mark.integration
|
|
|
|
|
|
@pytest.fixture(scope='module')
|
|
def mock_circular_import_chain():
|
|
"""Break circular import chain for API controller."""
|
|
from tests.utils.import_isolation import isolated_sys_modules, MockLifecycleControlScope
|
|
|
|
class FakeMinimalApplication:
|
|
pass
|
|
|
|
mock_app = MagicMock()
|
|
mock_app.Application = FakeMinimalApplication
|
|
|
|
mock_entities = MagicMock()
|
|
mock_entities.LifecycleControlScope = MockLifecycleControlScope
|
|
|
|
clear = [
|
|
'langbot.pkg.api.http.controller.group',
|
|
'langbot.pkg.api.http.controller.groups',
|
|
'langbot.pkg.api.http.controller.groups.platform',
|
|
'langbot.pkg.api.http.controller.groups.platform.bots',
|
|
'langbot.pkg.api.http.controller.groups.platform.adapters',
|
|
'langbot.pkg.api.http.controller.main',
|
|
]
|
|
|
|
with isolated_sys_modules(
|
|
mocks={
|
|
'langbot.pkg.core.app': mock_app,
|
|
'langbot.pkg.core.entities': mock_entities,
|
|
},
|
|
clear=clear,
|
|
):
|
|
import langbot.pkg.api.http.controller.groups.platform.bots as _bots # noqa: E402, F401
|
|
|
|
yield
|
|
|
|
|
|
@pytest.fixture(scope='module')
|
|
def fake_bot_app():
|
|
"""Create FakeApp with bot services (module scope for reuse)."""
|
|
app = FakeApp()
|
|
|
|
app.instance_config.data.update(
|
|
{
|
|
'api': {'port': 5300},
|
|
'system': {'allow_modify_login_info': True, 'limitation': {}},
|
|
}
|
|
)
|
|
|
|
# Auth services
|
|
account = SimpleNamespace(uuid='account-test', user='test@example.com')
|
|
app.user_service = Mock()
|
|
app.user_service.is_initialized = AsyncMock(return_value=True)
|
|
app.user_service.verify_jwt_token = AsyncMock(return_value='test@example.com')
|
|
app.user_service.get_user_by_email = AsyncMock(return_value=account)
|
|
app.user_service.get_authenticated_account = AsyncMock(return_value=account)
|
|
app.workspace_collaboration_service = SimpleNamespace(
|
|
resolve_account_workspace=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
workspace=SimpleNamespace(uuid='workspace-test'),
|
|
membership=SimpleNamespace(
|
|
uuid='membership-test',
|
|
role='owner',
|
|
projection_revision=0,
|
|
),
|
|
execution=SimpleNamespace(instance_uuid='instance-test', placement_generation=1),
|
|
)
|
|
)
|
|
)
|
|
app.apikey_service = Mock()
|
|
app.apikey_service.verify_api_key = AsyncMock(return_value=True)
|
|
app.apikey_service.authenticate_api_key = AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
instance_uuid='instance-test',
|
|
placement_generation=1,
|
|
api_key_uuid='api-key-test',
|
|
workspace_uuid='workspace-test',
|
|
permissions=frozenset(
|
|
{
|
|
'resource.view',
|
|
'resource.manage',
|
|
'runtime.operate',
|
|
'provider_secret.manage',
|
|
}
|
|
),
|
|
)
|
|
)
|
|
|
|
# Bot service
|
|
app.bot_service = Mock()
|
|
app.bot_service.get_bots = AsyncMock(
|
|
return_value=[
|
|
{
|
|
'uuid': 'test-bot-uuid',
|
|
'name': 'Test Bot',
|
|
'platform': 'telegram',
|
|
'pipeline_uuid': 'test-pipeline-uuid',
|
|
}
|
|
]
|
|
)
|
|
app.bot_service.get_runtime_bot_info = AsyncMock(
|
|
return_value={
|
|
'uuid': 'test-bot-uuid',
|
|
'name': 'Test Bot',
|
|
'platform': 'telegram',
|
|
'pipeline_uuid': 'test-pipeline-uuid',
|
|
'webhook_url': 'https://example.com/webhook/test-bot-uuid',
|
|
}
|
|
)
|
|
app.bot_service.create_bot = AsyncMock(return_value={'uuid': 'new-bot-uuid'})
|
|
app.bot_service.update_bot = AsyncMock(return_value={})
|
|
app.bot_service.delete_bot = AsyncMock()
|
|
app.bot_service.list_event_logs = AsyncMock(return_value=([{'uuid': 'log-1', 'message': 'test log'}], 1))
|
|
app.bot_service.send_message = AsyncMock()
|
|
|
|
# Platform manager
|
|
app.platform_mgr = Mock()
|
|
|
|
return app
|
|
|
|
|
|
@pytest.fixture(scope='module')
|
|
async def quart_test_client(fake_bot_app, http_controller_cls):
|
|
"""Create Quart test client (module scope to avoid route re-registration)."""
|
|
controller = http_controller_cls(fake_bot_app)
|
|
await controller.initialize()
|
|
|
|
client = controller.quart_app.test_client()
|
|
yield client
|
|
|
|
|
|
@pytest.mark.usefixtures('mock_circular_import_chain')
|
|
class TestBotEndpoints:
|
|
"""Tests for /api/v1/platform/bots endpoints."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_bots_success(self, quart_test_client):
|
|
"""GET /api/v1/platform/bots returns bot list."""
|
|
response = await quart_test_client.get('/api/v1/platform/bots', headers={'Authorization': 'Bearer test_token'})
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
assert 'data' in data
|
|
assert 'bots' in data['data']
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_bot_success(self, quart_test_client):
|
|
"""POST /api/v1/platform/bots creates new bot."""
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots',
|
|
headers={'Authorization': 'Bearer test_token'},
|
|
json={'name': 'New Bot', 'platform': 'telegram', 'pipeline_uuid': 'test-pipeline'},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
assert 'uuid' in data['data']
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_single_bot_success(self, quart_test_client):
|
|
"""GET /api/v1/platform/bots/{uuid} returns bot with runtime info."""
|
|
response = await quart_test_client.get(
|
|
'/api/v1/platform/bots/test-bot-uuid', headers={'Authorization': 'Bearer test_token'}
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
assert 'bot' in data['data']
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_update_bot_success(self, quart_test_client):
|
|
"""PUT /api/v1/platform/bots/{uuid} updates bot."""
|
|
response = await quart_test_client.put(
|
|
'/api/v1/platform/bots/test-bot-uuid',
|
|
headers={'Authorization': 'Bearer test_token'},
|
|
json={'name': 'Updated Bot'},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_delete_bot_success(self, quart_test_client):
|
|
"""DELETE /api/v1/platform/bots/{uuid} deletes bot."""
|
|
response = await quart_test_client.delete(
|
|
'/api/v1/platform/bots/test-bot-uuid', headers={'Authorization': 'Bearer test_token'}
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
|
|
|
|
@pytest.mark.usefixtures('mock_circular_import_chain')
|
|
class TestBotLogsEndpoint:
|
|
"""Tests for bot logs endpoint."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_bot_logs_success(self, quart_test_client):
|
|
"""POST /api/v1/platform/bots/{uuid}/logs returns logs."""
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots/test-bot-uuid/logs',
|
|
headers={'Authorization': 'Bearer test_token'},
|
|
json={'from_index': -1, 'max_count': 10},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
assert 'logs' in data['data']
|
|
assert 'total_count' in data['data']
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_viewer_can_read_ordinary_bot_logs(self, quart_test_client, fake_bot_app):
|
|
access = fake_bot_app.workspace_collaboration_service.resolve_account_workspace.return_value
|
|
original_role = access.membership.role
|
|
access.membership.role = 'viewer'
|
|
fake_bot_app.bot_service.list_event_logs.reset_mock()
|
|
try:
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots/test-bot-uuid/logs',
|
|
headers={'Authorization': 'Bearer test_token'},
|
|
json={'from_index': -1, 'max_count': 10},
|
|
)
|
|
finally:
|
|
access.membership.role = original_role
|
|
|
|
assert response.status_code == 200
|
|
assert (await response.get_json())['code'] == 0
|
|
fake_bot_app.bot_service.list_event_logs.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.usefixtures('mock_circular_import_chain')
|
|
class TestBotSendMessageEndpoint:
|
|
"""Tests for bot send message endpoint."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_message_success(self, quart_test_client):
|
|
"""POST /api/v1/platform/bots/{uuid}/send_message sends message."""
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots/test-bot-uuid/send_message',
|
|
headers={'Authorization': 'Bearer test_api_key'},
|
|
json={
|
|
'target_type': 'person',
|
|
'target_id': 'user123',
|
|
'message_chain': [{'type': 'text', 'text': 'Hello'}],
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = await response.get_json()
|
|
assert data['code'] == 0
|
|
assert data['data']['sent'] is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_message_missing_target_type(self, quart_test_client):
|
|
"""POST send_message without target_type returns 400."""
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots/test-bot-uuid/send_message',
|
|
headers={'Authorization': 'Bearer test_api_key'},
|
|
json={'target_id': 'user123', 'message_chain': [{'type': 'text', 'text': 'Hello'}]},
|
|
)
|
|
|
|
assert response.status_code == 400
|
|
data = await response.get_json()
|
|
assert data['code'] == -1
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_send_message_invalid_target_type(self, quart_test_client):
|
|
"""POST send_message with invalid target_type returns 400."""
|
|
response = await quart_test_client.post(
|
|
'/api/v1/platform/bots/test-bot-uuid/send_message',
|
|
headers={'Authorization': 'Bearer test_api_key'},
|
|
json={
|
|
'target_type': 'invalid',
|
|
'target_id': 'user123',
|
|
'message_chain': [{'type': 'text', 'text': 'Hello'}],
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 400
|
|
data = await response.get_json()
|
|
assert data['code'] == -1
|