mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-07 03:46:38 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
255 lines
9.2 KiB
Python
255 lines
9.2 KiB
Python
from __future__ import annotations
|
|
|
|
import asyncio
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, Mock
|
|
|
|
import lark_oapi
|
|
import pytest
|
|
import quart
|
|
|
|
from langbot.pkg.api.http.context import (
|
|
PrincipalContext,
|
|
PrincipalType,
|
|
RequestContext,
|
|
WorkspaceContext,
|
|
)
|
|
from langbot.pkg.api.http.controller.groups.platform.adapters import (
|
|
AdaptersRouterGroup,
|
|
_AdapterSessionScope,
|
|
_bind_session_scope,
|
|
_get_owned_session,
|
|
_make_room_for_session,
|
|
_pop_owned_session,
|
|
_start_adapter_session_task,
|
|
)
|
|
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
SENSITIVE_ADAPTER_ROUTES = (
|
|
('post', '/api/v1/platform/adapters/lark/create-app'),
|
|
('get', '/api/v1/platform/adapters/lark/create-app/status/missing'),
|
|
('delete', '/api/v1/platform/adapters/lark/create-app/missing'),
|
|
('post', '/api/v1/platform/adapters/weixin/login'),
|
|
('get', '/api/v1/platform/adapters/weixin/login/status/missing'),
|
|
('delete', '/api/v1/platform/adapters/weixin/login/missing'),
|
|
('post', '/api/v1/platform/adapters/dingtalk/create-app'),
|
|
('get', '/api/v1/platform/adapters/dingtalk/create-app/status/missing'),
|
|
('delete', '/api/v1/platform/adapters/dingtalk/create-app/missing'),
|
|
('post', '/api/v1/platform/adapters/wecombot/create-bot'),
|
|
('get', '/api/v1/platform/adapters/wecombot/create-bot/status/missing'),
|
|
('delete', '/api/v1/platform/adapters/wecombot/create-bot/missing'),
|
|
('post', '/api/v1/platform/adapters/qqofficial/bind'),
|
|
('get', '/api/v1/platform/adapters/qqofficial/bind/status/missing'),
|
|
('delete', '/api/v1/platform/adapters/qqofficial/bind/missing'),
|
|
)
|
|
|
|
|
|
def _request_context(
|
|
*,
|
|
account_uuid: str = 'account-a',
|
|
workspace_uuid: str = 'workspace-a',
|
|
placement_generation: int = 1,
|
|
) -> RequestContext:
|
|
return RequestContext(
|
|
instance_uuid='instance-test',
|
|
placement_generation=placement_generation,
|
|
request_id='request-test',
|
|
auth_type='user-token',
|
|
principal=PrincipalContext(
|
|
principal_type=PrincipalType.ACCOUNT,
|
|
account_uuid=account_uuid,
|
|
),
|
|
workspace=WorkspaceContext(
|
|
workspace_uuid=workspace_uuid,
|
|
membership_uuid='membership-test',
|
|
role='developer',
|
|
permissions=frozenset({'resource.manage'}),
|
|
),
|
|
)
|
|
|
|
|
|
async def _create_client(*, role: str = 'developer'):
|
|
quart_app = quart.Quart(__name__)
|
|
accounts = {
|
|
'owner-token': SimpleNamespace(uuid='account-a', user='owner@example.com'),
|
|
'other-token': SimpleNamespace(uuid='account-b', user='other@example.com'),
|
|
}
|
|
|
|
async def get_authenticated_account(token: str):
|
|
return accounts[token]
|
|
|
|
async def resolve_account_workspace(account_uuid: str, requested_workspace_uuid: str | None):
|
|
workspace_uuid = requested_workspace_uuid or 'workspace-a'
|
|
return SimpleNamespace(
|
|
execution=SimpleNamespace(
|
|
instance_uuid='instance-test',
|
|
placement_generation=1,
|
|
),
|
|
workspace=SimpleNamespace(uuid=workspace_uuid),
|
|
membership=SimpleNamespace(
|
|
uuid=f'membership-{account_uuid}-{workspace_uuid}',
|
|
role=role,
|
|
projection_revision=1,
|
|
),
|
|
)
|
|
|
|
class TestTaskManager:
|
|
def create_user_task(self, coro, **_kwargs):
|
|
return SimpleNamespace(task=asyncio.create_task(coro))
|
|
|
|
application = SimpleNamespace(
|
|
user_service=SimpleNamespace(
|
|
get_authenticated_account=AsyncMock(side_effect=get_authenticated_account),
|
|
),
|
|
workspace_collaboration_service=SimpleNamespace(
|
|
resolve_account_workspace=AsyncMock(side_effect=resolve_account_workspace),
|
|
),
|
|
platform_mgr=SimpleNamespace(),
|
|
task_mgr=TestTaskManager(),
|
|
)
|
|
router = AdaptersRouterGroup(application, quart_app)
|
|
await router.initialize()
|
|
return quart_app.test_client()
|
|
|
|
|
|
@pytest.mark.parametrize(('method', 'path'), SENSITIVE_ADAPTER_ROUTES)
|
|
async def test_sensitive_adapter_flows_require_resource_manage(method: str, path: str):
|
|
client = await _create_client(role='viewer')
|
|
|
|
response = await getattr(client, method)(
|
|
path,
|
|
headers={'Authorization': 'Bearer owner-token'},
|
|
)
|
|
|
|
assert response.status_code == 403
|
|
assert (await response.get_json())['code'] == 'permission_denied'
|
|
|
|
|
|
async def test_session_scope_matches_exact_tenant_placement_and_principal():
|
|
owner_context = _request_context()
|
|
sessions: dict[str, dict] = {'session-test': {'status': 'waiting'}}
|
|
_bind_session_scope(sessions['session-test'], owner_context)
|
|
|
|
assert sessions['session-test']['scope'] == _AdapterSessionScope.from_request_context(owner_context)
|
|
assert _get_owned_session(sessions, 'session-test', owner_context) is sessions['session-test']
|
|
|
|
for other_context in (
|
|
_request_context(account_uuid='account-b'),
|
|
_request_context(workspace_uuid='workspace-b'),
|
|
_request_context(placement_generation=2),
|
|
):
|
|
assert _get_owned_session(sessions, 'session-test', other_context) is None
|
|
assert _pop_owned_session(sessions, 'session-test', other_context) is None
|
|
assert 'session-test' in sessions
|
|
|
|
assert _pop_owned_session(sessions, 'session-test', owner_context) is not None
|
|
assert sessions == {}
|
|
|
|
|
|
async def test_session_capacity_evicts_oldest_session_in_same_workspace():
|
|
owner_context = _request_context()
|
|
sessions: dict[str, dict] = {}
|
|
tasks = []
|
|
for index in range(10):
|
|
task = SimpleNamespace(done=Mock(return_value=False), cancel=Mock())
|
|
tasks.append(task)
|
|
session = {'created_at': float(index), 'task': task}
|
|
_bind_session_scope(session, owner_context)
|
|
sessions[f'session-{index}'] = session
|
|
|
|
_make_room_for_session(sessions, owner_context)
|
|
|
|
assert 'session-0' not in sessions
|
|
assert len(sessions) == 9
|
|
tasks[0].cancel.assert_called_once_with()
|
|
|
|
|
|
async def test_adapter_session_task_uses_tenant_task_admission():
|
|
blocker = asyncio.Event()
|
|
|
|
async def credential_exchange():
|
|
await blocker.wait()
|
|
|
|
task_manager = SimpleNamespace(create_user_task=Mock())
|
|
|
|
def create_user_task(coro, **_kwargs):
|
|
return SimpleNamespace(task=asyncio.create_task(coro))
|
|
|
|
task_manager.create_user_task.side_effect = create_user_task
|
|
application = SimpleNamespace(task_mgr=task_manager)
|
|
request_context = _request_context()
|
|
|
|
returned = _start_adapter_session_task(
|
|
application,
|
|
credential_exchange(),
|
|
adapter='lark',
|
|
session_id='session-test',
|
|
request_context=request_context,
|
|
)
|
|
|
|
assert returned is not None
|
|
task_manager.create_user_task.assert_called_once()
|
|
kwargs = task_manager.create_user_task.call_args.kwargs
|
|
assert kwargs['kind'] == 'platform-adapter-credential-exchange'
|
|
assert kwargs['instance_uuid'] == request_context.instance_uuid
|
|
assert kwargs['workspace_uuid'] == request_context.workspace_uuid
|
|
assert kwargs['placement_generation'] == request_context.placement_generation
|
|
blocker.set()
|
|
await returned
|
|
|
|
|
|
async def test_lark_session_status_and_delete_hide_cross_scope_sessions(monkeypatch):
|
|
registration_blocker = asyncio.Event()
|
|
|
|
async def fake_register_app(*, on_qr_code, source: str):
|
|
assert source == 'langbot'
|
|
on_qr_code({'url': 'https://example.test/lark-qr'})
|
|
await registration_blocker.wait()
|
|
raise AssertionError('registration should have been cancelled')
|
|
|
|
monkeypatch.setattr(lark_oapi, 'aregister_app', fake_register_app)
|
|
client = await _create_client()
|
|
owner_headers = {
|
|
'Authorization': 'Bearer owner-token',
|
|
'X-Workspace-Id': 'workspace-a',
|
|
}
|
|
|
|
create_response = await client.post(
|
|
'/api/v1/platform/adapters/lark/create-app',
|
|
headers=owner_headers,
|
|
)
|
|
assert create_response.status_code == 200
|
|
session_id = (await create_response.get_json())['data']['session_id']
|
|
status_path = f'/api/v1/platform/adapters/lark/create-app/status/{session_id}'
|
|
delete_path = f'/api/v1/platform/adapters/lark/create-app/{session_id}'
|
|
|
|
for headers in (
|
|
{
|
|
'Authorization': 'Bearer other-token',
|
|
'X-Workspace-Id': 'workspace-a',
|
|
},
|
|
{
|
|
'Authorization': 'Bearer owner-token',
|
|
'X-Workspace-Id': 'workspace-b',
|
|
},
|
|
):
|
|
status_response = await client.get(status_path, headers=headers)
|
|
delete_response = await client.delete(delete_path, headers=headers)
|
|
assert status_response.status_code == 404
|
|
assert delete_response.status_code == 404
|
|
assert (await status_response.get_json())['msg'] == 'Session not found'
|
|
assert (await delete_response.get_json())['msg'] == 'Session not found'
|
|
|
|
owner_status_response = await client.get(status_path, headers=owner_headers)
|
|
assert owner_status_response.status_code == 200
|
|
assert (await owner_status_response.get_json())['data']['status'] == 'waiting'
|
|
|
|
owner_delete_response = await client.delete(delete_path, headers=owner_headers)
|
|
assert owner_delete_response.status_code == 200
|
|
missing_delete_response = await client.delete(delete_path, headers=owner_headers)
|
|
assert missing_delete_response.status_code == 404
|
|
await asyncio.sleep(0)
|