mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-07 03:46:38 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
165 lines
6.2 KiB
Python
165 lines
6.2 KiB
Python
from __future__ import annotations
|
|
|
|
import base64
|
|
import json
|
|
import time
|
|
import uuid
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
from cryptography.hazmat.primitives import serialization
|
|
from cryptography.hazmat.primitives.asymmetric.ed25519 import Ed25519PrivateKey
|
|
|
|
from langbot.pkg.cloud.launch import SpaceLaunchError, SpaceLaunchService
|
|
|
|
|
|
pytestmark = pytest.mark.asyncio
|
|
|
|
|
|
INSTANCE_UUID = 'instance-test'
|
|
ACCOUNT_UUID = '11111111-1111-4111-8111-111111111111'
|
|
WORKSPACE_UUID = '22222222-2222-4222-8222-222222222222'
|
|
KEY_ID = 'space-key-1'
|
|
|
|
|
|
def _base64url(raw: bytes) -> str:
|
|
return base64.urlsafe_b64encode(raw).rstrip(b'=').decode('ascii')
|
|
|
|
|
|
def _sign(private_key: Ed25519PrivateKey, claims: dict, *, key_id: str = KEY_ID) -> str:
|
|
header = {'alg': 'EdDSA', 'kid': key_id, 'typ': 'langbot-control-plane+jwt'}
|
|
encoded_header = _base64url(json.dumps(header, separators=(',', ':')).encode('utf-8'))
|
|
encoded_claims = _base64url(json.dumps(claims, separators=(',', ':')).encode('utf-8'))
|
|
signing_input = f'{encoded_header}.{encoded_claims}'
|
|
return f'{signing_input}.{_base64url(private_key.sign(signing_input.encode("ascii")))}'
|
|
|
|
|
|
def _claims(*, now: int, jti: str | None = None, workspace_uuid: str = WORKSPACE_UUID) -> dict:
|
|
return {
|
|
'iss': 'langbot-space',
|
|
'aud': 'langbot-cloud-runtime',
|
|
'sub': f'langbot-instance:{INSTANCE_UUID}',
|
|
'jti': jti or str(uuid.uuid4()),
|
|
'iat': now,
|
|
'nbf': now - 5,
|
|
'exp': now + 90,
|
|
'instance_uuid': INSTANCE_UUID,
|
|
'kind': 'workspace.launch',
|
|
'payload': {
|
|
'account_uuid': ACCOUNT_UUID,
|
|
'workspace_uuid': workspace_uuid,
|
|
},
|
|
}
|
|
|
|
|
|
def _service(private_key: Ed25519PrivateKey, *, now: int) -> SpaceLaunchService:
|
|
public_key = private_key.public_key().public_bytes(
|
|
encoding=serialization.Encoding.Raw,
|
|
format=serialization.PublicFormat.Raw,
|
|
)
|
|
app = SimpleNamespace(
|
|
deployment=SimpleNamespace(multi_workspace_enabled=True, verification_key_id=KEY_ID),
|
|
workspace_service=SimpleNamespace(instance_uuid=INSTANCE_UUID),
|
|
instance_config=SimpleNamespace(
|
|
data={
|
|
'space': {
|
|
'launch': {
|
|
'control_plane_public_key': _base64url(public_key),
|
|
}
|
|
}
|
|
}
|
|
),
|
|
)
|
|
return SpaceLaunchService(app, wall_time=lambda: now)
|
|
|
|
|
|
async def test_consumes_valid_workspace_launch_assertion_once():
|
|
private_key = Ed25519PrivateKey.generate()
|
|
now = int(time.time())
|
|
service = _service(private_key, now=now)
|
|
token = _sign(private_key, _claims(now=now))
|
|
|
|
launch = await service.consume_assertion(token, expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
assert launch == {'account_uuid': ACCOUNT_UUID, 'workspace_uuid': WORKSPACE_UUID}
|
|
with pytest.raises(SpaceLaunchError, match='already been consumed'):
|
|
await service.consume_assertion(token, expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
|
|
async def test_replay_cache_does_not_scan_all_live_assertions(monkeypatch):
|
|
private_key = Ed25519PrivateKey.generate()
|
|
now = int(time.time())
|
|
service = _service(private_key, now=now)
|
|
for index in range(512):
|
|
await service._consume_jti(f'jti-{index}', now + 90)
|
|
|
|
class NoGlobalIterationDict(dict):
|
|
def __iter__(self):
|
|
raise AssertionError('replay admission scanned all live assertions')
|
|
|
|
def keys(self):
|
|
raise AssertionError('replay admission scanned all live assertions')
|
|
|
|
def items(self):
|
|
raise AssertionError('replay admission scanned all live assertions')
|
|
|
|
def values(self):
|
|
raise AssertionError('replay admission scanned all live assertions')
|
|
|
|
guarded_jtis = NoGlobalIterationDict(service._consumed_jtis)
|
|
monkeypatch.setattr(service, '_consumed_jtis', guarded_jtis)
|
|
|
|
await service._consume_jti('jti-new', now + 90)
|
|
|
|
assert len(guarded_jtis) == 513
|
|
|
|
|
|
async def test_replay_cache_fails_closed_at_capacity(monkeypatch):
|
|
from langbot.pkg.cloud import launch
|
|
|
|
private_key = Ed25519PrivateKey.generate()
|
|
now = int(time.time())
|
|
service = _service(private_key, now=now)
|
|
monkeypatch.setattr(launch, '_CONSUMED_JTI_MAX_ENTRIES', 2)
|
|
await service._consume_jti('jti-1', now + 90)
|
|
await service._consume_jti('jti-2', now + 90)
|
|
|
|
with pytest.raises(SpaceLaunchError, match='replay cache capacity'):
|
|
await service._consume_jti('jti-3', now + 90)
|
|
with pytest.raises(SpaceLaunchError, match='already been consumed'):
|
|
await service._consume_jti('jti-1', now + 90)
|
|
|
|
|
|
async def test_rejects_expired_wrong_workspace_and_wrong_instance_assertions():
|
|
private_key = Ed25519PrivateKey.generate()
|
|
now = int(time.time())
|
|
service = _service(private_key, now=now)
|
|
|
|
expired = _claims(now=now)
|
|
expired['exp'] = now - 60
|
|
with pytest.raises(SpaceLaunchError, match='expired'):
|
|
await service.consume_assertion(_sign(private_key, expired), expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
wrong_workspace = _sign(private_key, _claims(now=now, workspace_uuid='33333333-3333-4333-8333-333333333333'))
|
|
with pytest.raises(SpaceLaunchError, match='another Workspace'):
|
|
await service.consume_assertion(wrong_workspace, expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
wrong_instance = _claims(now=now)
|
|
wrong_instance['instance_uuid'] = 'other-instance'
|
|
with pytest.raises(SpaceLaunchError, match='instance UUID'):
|
|
await service.consume_assertion(_sign(private_key, wrong_instance), expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
|
|
async def test_rejects_invalid_signature_and_non_cloud_mode():
|
|
private_key = Ed25519PrivateKey.generate()
|
|
now = int(time.time())
|
|
token = _sign(private_key, _claims(now=now))
|
|
service = _service(Ed25519PrivateKey.generate(), now=now)
|
|
with pytest.raises(SpaceLaunchError, match='signature'):
|
|
await service.consume_assertion(token, expected_workspace_uuid=WORKSPACE_UUID)
|
|
|
|
oss_service = _service(private_key, now=now)
|
|
oss_service.ap.deployment.multi_workspace_enabled = False
|
|
with pytest.raises(SpaceLaunchError, match='verified Cloud mode'):
|
|
await oss_service.consume_assertion(token, expected_workspace_uuid=WORKSPACE_UUID)
|