mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-08 20:30:59 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
117 lines
4.5 KiB
Python
117 lines
4.5 KiB
Python
from __future__ import annotations
|
|
|
|
from datetime import datetime, timedelta
|
|
from importlib import import_module
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, Mock
|
|
|
|
import pytest
|
|
import yaml
|
|
from langbot_plugin.api.entities.builtin.provider import session as provider_session
|
|
|
|
|
|
def _preproc_module():
|
|
# Import pipelinemgr first so pipeline stages are registered without tripping
|
|
# the stage <-> core.app circular import during isolated test collection.
|
|
import_module('langbot.pkg.pipeline.pipelinemgr')
|
|
return import_module('langbot.pkg.pipeline.preproc.preproc')
|
|
|
|
|
|
def _entities_module():
|
|
return import_module('langbot.pkg.pipeline.entities')
|
|
|
|
|
|
def _conversation(created_at: datetime, updated_at: datetime | None = None):
|
|
prompt = Mock()
|
|
prompt.messages = []
|
|
prompt.copy = Mock(return_value=Mock(messages=[]))
|
|
|
|
return SimpleNamespace(
|
|
uuid='existing-conversation-uuid',
|
|
create_time=created_at,
|
|
update_time=updated_at,
|
|
prompt=prompt,
|
|
messages=[],
|
|
)
|
|
|
|
|
|
def _prompt_preprocessing_context(default_prompt=None, prompt=None):
|
|
ctx = Mock()
|
|
ctx.event.default_prompt = default_prompt or []
|
|
ctx.event.prompt = prompt or []
|
|
return ctx
|
|
|
|
|
|
async def _run_preprocessor(mock_app, sample_query, conversation):
|
|
session = provider_session.Session(
|
|
launcher_type=sample_query.launcher_type,
|
|
launcher_id=sample_query.launcher_id,
|
|
sender_id=sample_query.sender_id,
|
|
bot_uuid=sample_query.bot_uuid,
|
|
)
|
|
mock_app.sess_mgr.get_session = AsyncMock(return_value=session)
|
|
mock_app.sess_mgr.get_conversation = AsyncMock(return_value=conversation)
|
|
mock_app.plugin_connector.emit_event = AsyncMock(return_value=_prompt_preprocessing_context())
|
|
|
|
sample_query.pipeline_config = {
|
|
'ai': {
|
|
'runner': {'runner': 'local-agent', 'expire-time': 60},
|
|
'local-agent': {'model': {'primary': '', 'fallbacks': []}, 'prompt': []},
|
|
},
|
|
'trigger': {'misc': {'combine-quote-message': False}},
|
|
'output': {'misc': {'exception-handling': 'show-hint'}},
|
|
}
|
|
|
|
return await _preproc_module().PreProcessor(mock_app).process(sample_query, 'PreProcessor')
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_preprocessor_expires_conversation_from_last_update_time(mock_app, sample_query):
|
|
conversation = _conversation(
|
|
created_at=datetime.now() - timedelta(seconds=10),
|
|
updated_at=datetime.now() - timedelta(seconds=120),
|
|
)
|
|
|
|
result = await _run_preprocessor(mock_app, sample_query, conversation)
|
|
|
|
assert result.result_type == _entities_module().ResultType.CONTINUE
|
|
assert conversation.uuid is None
|
|
assert conversation.update_time > datetime.now() - timedelta(seconds=5)
|
|
assert result.new_query.variables['conversation_id'] is None
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_preprocessor_keeps_conversation_when_last_update_is_not_expired(mock_app, sample_query):
|
|
conversation = _conversation(
|
|
created_at=datetime.now() - timedelta(seconds=120),
|
|
updated_at=datetime.now() - timedelta(seconds=30),
|
|
)
|
|
|
|
result = await _run_preprocessor(mock_app, sample_query, conversation)
|
|
|
|
assert result.result_type == _entities_module().ResultType.CONTINUE
|
|
assert conversation.uuid == 'existing-conversation-uuid'
|
|
assert conversation.update_time > datetime.now() - timedelta(seconds=5)
|
|
assert result.new_query.variables['conversation_id'] == 'existing-conversation-uuid'
|
|
|
|
|
|
def test_expire_time_metadata_lives_under_ai_runner_not_safety():
|
|
# Use path relative to test file location for portability
|
|
# test file: tests/unit_tests/pipeline/test_chat_session_limit.py
|
|
# project root: 4 levels up
|
|
project_root = Path(__file__).parent.parent.parent.parent
|
|
metadata_dir = project_root / 'src' / 'langbot' / 'templates' / 'metadata' / 'pipeline'
|
|
|
|
ai_meta = yaml.safe_load((metadata_dir / 'ai.yaml').read_text())
|
|
safety_meta = yaml.safe_load((metadata_dir / 'safety.yaml').read_text())
|
|
|
|
ai_stage_names = [stage['name'] for stage in ai_meta['stages']]
|
|
assert 'session-limit' not in ai_stage_names
|
|
assert 'session-limit' not in [stage['name'] for stage in safety_meta['stages']]
|
|
|
|
runner_stage = next(stage for stage in ai_meta['stages'] if stage['name'] == 'runner')
|
|
expire_time = next(item for item in runner_stage['config'] if item['name'] == 'expire-time')
|
|
assert 'Conversation expire time' in expire_time['label']['en_US']
|
|
assert 'Session validity' not in expire_time['label']['en_US']
|