mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-05 19:16:07 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
63 lines
2.4 KiB
Python
63 lines
2.4 KiB
Python
"""Unit tests for plugin connector static methods.
|
|
|
|
Tests cover:
|
|
- _parse_plugin_id() parsing and validation
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from importlib import import_module
|
|
|
|
|
|
def get_connector_module():
|
|
"""Lazy import to avoid circular import issues."""
|
|
return import_module('langbot.pkg.plugin.connector')
|
|
|
|
|
|
class TestParsePluginId:
|
|
"""Tests for _parse_plugin_id static method."""
|
|
|
|
def test_valid_plugin_id_simple(self):
|
|
"""Test parsing valid plugin ID with simple format."""
|
|
connector = get_connector_module()
|
|
author, name = connector.PluginRuntimeConnector._parse_plugin_id('langbot/rag-engine')
|
|
assert author == 'langbot'
|
|
assert name == 'rag-engine'
|
|
|
|
def test_invalid_plugin_id_no_slash(self):
|
|
"""Test that ValueError is raised when no slash present."""
|
|
connector = get_connector_module()
|
|
with pytest.raises(ValueError) as exc_info:
|
|
connector.PluginRuntimeConnector._parse_plugin_id('invalid-plugin-id')
|
|
assert 'Invalid plugin_id format' in str(exc_info.value)
|
|
assert 'invalid-plugin-id' in str(exc_info.value)
|
|
|
|
def test_invalid_plugin_id_empty_string(self):
|
|
"""Test that ValueError is raised for empty string."""
|
|
connector = get_connector_module()
|
|
with pytest.raises(ValueError) as exc_info:
|
|
connector.PluginRuntimeConnector._parse_plugin_id('')
|
|
assert 'Invalid plugin_id format' in str(exc_info.value)
|
|
|
|
def test_valid_plugin_id_single_character_parts(self):
|
|
"""Test parsing plugin ID with single character author and name."""
|
|
connector = get_connector_module()
|
|
author, name = connector.PluginRuntimeConnector._parse_plugin_id('a/b')
|
|
assert author == 'a'
|
|
assert name == 'b'
|
|
|
|
def test_valid_plugin_id_with_hyphens_and_underscores(self):
|
|
"""Test parsing plugin ID with hyphens and underscores."""
|
|
connector = get_connector_module()
|
|
author, name = connector.PluginRuntimeConnector._parse_plugin_id('lang-bot/my_rag_engine')
|
|
assert author == 'lang-bot'
|
|
assert name == 'my_rag_engine'
|
|
|
|
|
|
def test_runtime_id_is_stable_across_core_restarts(monkeypatch):
|
|
connector = get_connector_module()
|
|
monkeypatch.setattr(connector.constants, 'instance_id', 'instance-a')
|
|
|
|
assert connector.PluginRuntimeConnector._build_runtime_id() == 'instance-a:plugin-runtime'
|