mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-09-01 15:17:15 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
227 lines
8.8 KiB
Python
227 lines
8.8 KiB
Python
from __future__ import annotations
|
|
|
|
import posixpath
|
|
import re
|
|
from typing import TYPE_CHECKING, Any
|
|
from urllib.parse import unquote
|
|
|
|
import sqlalchemy
|
|
|
|
from langbot.pkg.api.http.authz import WorkspaceRequiredError
|
|
from langbot.pkg.api.http.context import ExecutionContext
|
|
from langbot.pkg.entity.persistence import rag as persistence_rag
|
|
from langbot.pkg.workspace.errors import WorkspaceNotFoundError
|
|
|
|
if TYPE_CHECKING:
|
|
from langbot.pkg.core import app
|
|
|
|
|
|
class RAGRuntimeService:
|
|
"""Service to handle RAG-related requests from plugins (Runtime).
|
|
|
|
This service acts as the bridge between plugin RPC requests and
|
|
LangBot's infrastructure (embedding models, vector databases, file storage).
|
|
"""
|
|
|
|
def __init__(self, ap: app.Application):
|
|
self.ap = ap
|
|
|
|
async def _validate_execution_context(self, execution_context: ExecutionContext) -> None:
|
|
if not isinstance(execution_context, ExecutionContext):
|
|
raise WorkspaceRequiredError('ExecutionContext is required for RAG runtime access')
|
|
if (
|
|
not execution_context.instance_uuid.strip()
|
|
or not execution_context.workspace_uuid.strip()
|
|
or execution_context.placement_generation <= 0
|
|
):
|
|
raise WorkspaceRequiredError('A complete active ExecutionContext is required')
|
|
workspace_service = getattr(self.ap, 'workspace_service', None)
|
|
if workspace_service is None:
|
|
raise WorkspaceRequiredError('Workspace execution service is unavailable')
|
|
binding = await workspace_service.get_execution_binding(
|
|
execution_context.workspace_uuid,
|
|
expected_generation=execution_context.placement_generation,
|
|
)
|
|
if binding.instance_uuid != execution_context.instance_uuid:
|
|
raise WorkspaceRequiredError('ExecutionContext belongs to another LangBot instance')
|
|
|
|
async def _resolve_knowledge_base_uuid(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
collection_id: str,
|
|
) -> str:
|
|
"""Resolve a plugin logical handle to a Workspace-owned KB UUID."""
|
|
|
|
await self._validate_execution_context(execution_context)
|
|
if not isinstance(collection_id, str) or not collection_id.strip():
|
|
raise WorkspaceNotFoundError('Knowledge base not found')
|
|
result = await self.ap.persistence_mgr.execute_async(
|
|
sqlalchemy.select(persistence_rag.KnowledgeBase.uuid)
|
|
.where(persistence_rag.KnowledgeBase.workspace_uuid == execution_context.workspace_uuid)
|
|
.where(
|
|
sqlalchemy.or_(
|
|
persistence_rag.KnowledgeBase.uuid == collection_id,
|
|
persistence_rag.KnowledgeBase.collection_id == collection_id,
|
|
)
|
|
)
|
|
.limit(1)
|
|
)
|
|
kb_uuid = result.scalar_one_or_none()
|
|
if kb_uuid is None:
|
|
raise WorkspaceNotFoundError('Knowledge base not found')
|
|
return kb_uuid
|
|
|
|
async def vector_upsert(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
collection_id: str,
|
|
vectors: list[list[float]],
|
|
ids: list[str],
|
|
metadata: list[dict[str, Any]] | None = None,
|
|
documents: list[str] | None = None,
|
|
) -> None:
|
|
"""Handle VECTOR_UPSERT action."""
|
|
knowledge_base_uuid = await self._resolve_knowledge_base_uuid(execution_context, collection_id)
|
|
if len(vectors) != len(ids):
|
|
raise ValueError('vectors and ids must have the same length')
|
|
if metadata is not None and len(metadata) != len(vectors):
|
|
raise ValueError('metadata must have the same length as vectors')
|
|
if documents is not None and len(documents) != len(vectors):
|
|
raise ValueError('documents must have the same length as vectors')
|
|
metadatas = metadata if metadata else [{} for _ in vectors]
|
|
await self.ap.vector_db_mgr.upsert(
|
|
execution_context=execution_context,
|
|
knowledge_base_uuid=knowledge_base_uuid,
|
|
vectors=vectors,
|
|
ids=ids,
|
|
metadata=metadatas,
|
|
documents=documents,
|
|
)
|
|
|
|
async def vector_search(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
collection_id: str,
|
|
query_vector: list[float],
|
|
top_k: int,
|
|
filters: dict[str, Any] | None = None,
|
|
search_type: str = 'vector',
|
|
query_text: str = '',
|
|
vector_weight: float | None = None,
|
|
) -> list[dict[str, Any]]:
|
|
"""Handle VECTOR_SEARCH action."""
|
|
knowledge_base_uuid = await self._resolve_knowledge_base_uuid(execution_context, collection_id)
|
|
return await self.ap.vector_db_mgr.search(
|
|
execution_context=execution_context,
|
|
knowledge_base_uuid=knowledge_base_uuid,
|
|
query_vector=query_vector,
|
|
limit=top_k,
|
|
filter=filters,
|
|
search_type=search_type,
|
|
query_text=query_text,
|
|
vector_weight=vector_weight,
|
|
)
|
|
|
|
async def vector_delete(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
collection_id: str,
|
|
file_ids: list[str] | None = None,
|
|
filters: dict[str, Any] | None = None,
|
|
) -> int:
|
|
"""Handle VECTOR_DELETE action.
|
|
|
|
Deletes vectors associated with the given file IDs from the collection.
|
|
Each file_id corresponds to a document whose vectors will be removed.
|
|
|
|
Args:
|
|
collection_id: The collection to delete from.
|
|
file_ids: File IDs whose associated vectors should be deleted.
|
|
Each file_id maps to a set of vectors stored with that file_id
|
|
in their metadata.
|
|
filters: Filter-based deletion (not yet supported, will raise).
|
|
"""
|
|
knowledge_base_uuid = await self._resolve_knowledge_base_uuid(execution_context, collection_id)
|
|
count = 0
|
|
if file_ids:
|
|
await self.ap.vector_db_mgr.delete_by_file_id(
|
|
execution_context=execution_context,
|
|
knowledge_base_uuid=knowledge_base_uuid,
|
|
file_ids=file_ids,
|
|
)
|
|
count = len(file_ids)
|
|
elif filters:
|
|
count = await self.ap.vector_db_mgr.delete_by_filter(
|
|
execution_context=execution_context,
|
|
knowledge_base_uuid=knowledge_base_uuid,
|
|
filter=filters,
|
|
)
|
|
return count
|
|
|
|
async def vector_list(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
collection_id: str,
|
|
filters: dict[str, Any] | None = None,
|
|
limit: int = 20,
|
|
offset: int = 0,
|
|
) -> tuple[list[dict[str, Any]], int]:
|
|
"""Handle VECTOR_LIST action.
|
|
|
|
Args:
|
|
collection_id: The collection to list from.
|
|
filters: Optional metadata filters.
|
|
limit: Maximum number of items to return.
|
|
offset: Number of items to skip.
|
|
|
|
Returns:
|
|
Tuple of (items, total).
|
|
"""
|
|
knowledge_base_uuid = await self._resolve_knowledge_base_uuid(execution_context, collection_id)
|
|
return await self.ap.vector_db_mgr.list_by_filter(
|
|
execution_context=execution_context,
|
|
knowledge_base_uuid=knowledge_base_uuid,
|
|
filter=filters,
|
|
limit=limit,
|
|
offset=offset,
|
|
)
|
|
|
|
async def get_file_stream(
|
|
self,
|
|
execution_context: ExecutionContext,
|
|
storage_path: str,
|
|
) -> bytes:
|
|
"""Handle GET_KNOWLEDEGE_FILE_STREAM action.
|
|
|
|
Uses the storage manager abstraction to load file content,
|
|
regardless of the underlying storage provider.
|
|
"""
|
|
# Validate storage_path to prevent path traversal
|
|
decoded_path = unquote(storage_path).replace('\\', '/')
|
|
decoded_segments = decoded_path.split('/')
|
|
normalized = posixpath.normpath(decoded_path)
|
|
if (
|
|
not storage_path
|
|
or '\x00' in decoded_path
|
|
or normalized.startswith('/')
|
|
or '..' in decoded_segments
|
|
or '..' in normalized.split('/')
|
|
or re.match(r'^[A-Za-z]:/', normalized)
|
|
):
|
|
raise ValueError('Invalid storage path')
|
|
await self._validate_execution_context(execution_context)
|
|
result = await self.ap.persistence_mgr.execute_async(
|
|
sqlalchemy.select(persistence_rag.File.uuid)
|
|
.where(persistence_rag.File.workspace_uuid == execution_context.workspace_uuid)
|
|
.where(persistence_rag.File.file_name == normalized)
|
|
.limit(1)
|
|
)
|
|
if result.first() is None:
|
|
raise WorkspaceNotFoundError('Knowledge file not found')
|
|
content_bytes = await self.ap.storage_mgr.load_scoped_object_key(
|
|
execution_context,
|
|
normalized,
|
|
expected_owner_type='upload_document',
|
|
)
|
|
return content_bytes if content_bytes else b''
|