mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-08-09 20:50:58 +00:00
e1ac5e0fc8
* Document multi-tenant workspace architecture * Add OSS and commercial workspace boundaries * docs: redesign multi-tenant workspace architecture * feat(tenancy): implement workspace isolation * docs(tenancy): record verification evidence * docs(tenancy): revise single-instance SaaS topology * docs(tenancy): refine architecture options * docs: finalize cloud v2 multi-tenant decisions * feat(tenancy): establish cloud isolation foundations * feat(tenancy): harden shared cloud runtime boundaries * docs(tenancy): record final isolation verification * fix(tenancy): close isolation and permission gaps * docs(tenancy): record final isolation verification * feat(tenancy): connect cloud workspace control plane * fix(build): install git for pinned SDK * docs(cloud): update control plane verification * chore: update multi-tenant SDK pin * fix(cloud): skip legacy model sync during startup * test(cloud): preserve minimal model manager fixtures * fix(cloud): preserve authenticated account context * fix(cloud): reuse authenticated account for user info * feat(cloud): complete Workspace settings navigation * test(web): cover Workspace dropdown menu * feat(web): place workspace controls in sidebar * refactor(web): streamline workspace controls * style(web): format workspace layout test * fix(cloud): surface runtime and workspace plan status * fix(plugin): keep runtime identity stable across restarts * fix(ui): widen and center workspace switcher * fix(ui): hide roles from workspace switcher * fix(ui): align workspace switcher with sidebar entries * feat(workspace): add in-product collaboration and direct Cloud launch * style: format collaboration changes * fix(workspace): bind collaboration APIs to tenant UoW * fix(cloud): preserve Core-owned collaboration state * test(cloud): require Space identity for invite registration * feat(cloud): complete secure invitation experience * style(web): format invitation flows * fix(cloud): recover box runtime without unscoped skill reload * feat(oss): enforce invitation account and owner billing flows * style: format OSS account service * test(oss): cover invitation logout handoff * fix(oss): resolve workspace owner in scoped session * feat(cloud): harden multi-tenant runtime resources * fix(cloud): bound runtime restart storms * fix(cloud): eliminate periodic runtime CPU spikes * fix(cloud): enforce instance capacity ceilings * fix(cloud): scope public login capability discovery * fix(cloud): bound tenant maintenance and monitoring work * fix(runtime): bound tenant resource amplification * fix(deps): pin green multi-tenant plugin SDK * fix(cloud): handle unavailable skill capability * fix(security): require authentication for image file endpoint (H-2) - Changed /api/v1/files/image from AuthType.NONE to USER_TOKEN_OR_API_KEY - Added Permission.RESOURCE_VIEW requirement - Prevents unauthenticated cross-tenant file access via leaked keys - Fixes HIGH severity finding from multi-tenant security review docs: add comprehensive database migration guide - Complete migration steps for OSS → multi-tenant - Backup, execution, verification procedures - Rollback scenarios and recovery plans - Performance tuning recommendations * test: add comprehensive cross-tenant isolation tests Added 7 critical test scenarios for multi-tenant boundaries: - Cross-tenant bot access prevention - Viewer role read-only enforcement - Removed member immediate access revocation - Model provider credential isolation - WebSocket message isolation - Invitation token workspace scoping - Multi-workspace context validation These tests address P0-2 coverage gaps for: - workspaces.py (membership & invitation flows) - user.py (authentication & authorization) - websocket_chat.py (real-time isolation) - plugins.py (resource access control) docs: finalize database migration guide * fix(security): resolve M-1, M-2, M-3 security findings M-1: WebSocket authorization TOCTOU race (FIXED) - Changed _revalidate_websocket_authorization to return RequestContext - Ensures validated context is used immediately without race window - Prevents removed members from sending messages during revalidation gap M-2: Model Manager cache workspace isolation (VERIFIED) - Confirmed _CacheKey already uses 4-tuple: (instance, workspace, generation, resource) - Cache is properly scoped per workspace, no cross-tenant leakage possible - No code change needed, documented as working correctly M-3: Invitation lock workspace scoping (FIXED) - Changed lock key from token_digest to workspace_uuid:token_digest - Prevents DoS where attacker locks token in Workspace A to block Workspace B - Locks now isolated per workspace All MEDIUM severity findings from security review now resolved. * fix(cloud): unblock tenant CI and enforce knowledge quotas * fix(tenancy): scope rerank model sync --------- Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
96 lines
3.0 KiB
Python
96 lines
3.0 KiB
Python
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, Mock
|
|
|
|
import pytest
|
|
import langbot_plugin.api.entities.builtin.platform.message as platform_message
|
|
|
|
from langbot.pkg.api.http.context import ExecutionContext
|
|
from langbot.pkg.platform.sources import openclaw_weixin
|
|
from langbot.pkg.platform.sources.openclaw_weixin import OpenClawWeixinAdapter
|
|
|
|
|
|
def make_adapter(*, execution_context: ExecutionContext | None):
|
|
app = SimpleNamespace(
|
|
persistence_mgr=SimpleNamespace(execute_async=AsyncMock()),
|
|
workspace_service=SimpleNamespace(
|
|
get_execution_binding=AsyncMock(
|
|
return_value=SimpleNamespace(
|
|
instance_uuid='instance-a',
|
|
workspace_uuid='workspace-a',
|
|
placement_generation=1,
|
|
)
|
|
)
|
|
),
|
|
)
|
|
logger = SimpleNamespace(
|
|
ap=app,
|
|
execution_context=execution_context,
|
|
warning=AsyncMock(),
|
|
)
|
|
adapter = OpenClawWeixinAdapter.model_construct(
|
|
config={'token': 'refreshed-token'},
|
|
logger=logger,
|
|
client=Mock(),
|
|
bot_account_id='',
|
|
listeners={},
|
|
name='openclaw-weixin',
|
|
)
|
|
adapter._bot_uuid = 'shared-bot-uuid'
|
|
return adapter, app, logger
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_persist_config_scopes_duplicate_bot_uuid_to_workspace():
|
|
adapter, app, _ = make_adapter(
|
|
execution_context=ExecutionContext(
|
|
instance_uuid='instance-a',
|
|
workspace_uuid='workspace-a',
|
|
placement_generation=1,
|
|
bot_uuid='shared-bot-uuid',
|
|
)
|
|
)
|
|
|
|
await adapter._persist_config()
|
|
|
|
app.workspace_service.get_execution_binding.assert_awaited_once_with(
|
|
'workspace-a',
|
|
expected_generation=1,
|
|
)
|
|
statement = app.persistence_mgr.execute_async.await_args.args[0]
|
|
params = statement.compile().params
|
|
assert 'workspace-a' in params.values()
|
|
assert 'shared-bot-uuid' in params.values()
|
|
assert {'workspace_uuid', 'uuid'} <= {comparison.left.name for comparison in statement._where_criteria}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.parametrize(
|
|
'execution_context',
|
|
[
|
|
None,
|
|
ExecutionContext(
|
|
instance_uuid='instance-a',
|
|
workspace_uuid='workspace-a',
|
|
placement_generation=1,
|
|
bot_uuid='another-bot-uuid',
|
|
),
|
|
],
|
|
ids=['missing-context', 'mismatched-bot'],
|
|
)
|
|
async def test_persist_config_fails_closed_without_matching_execution_context(execution_context):
|
|
adapter, app, logger = make_adapter(execution_context=execution_context)
|
|
|
|
await adapter._persist_config()
|
|
|
|
app.persistence_mgr.execute_async.assert_not_awaited()
|
|
logger.warning.assert_awaited_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_component_base64_decode_is_bounded(monkeypatch):
|
|
monkeypatch.setattr(openclaw_weixin, '_MAX_OPENCLAW_COMPONENT_BYTES', 4)
|
|
component = platform_message.File(base64='MTIzNDU=')
|
|
|
|
with pytest.raises(ValueError, match='exceeds'):
|
|
await OpenClawWeixinAdapter._get_component_bytes(component)
|