mirror of
https://github.com/Shadowss/TravianZ.git
synced 2026-06-30 09:34:28 +00:00
Ferywir
8c1a6ad05b
Issue #299: posting to an admin Mod (eg editBuildings.php) could show an essentially blank page. The admin panel and the game share the same PHP session, so a game logout (session_destroy) — or a mobile browser dropping the session cookie / serving a cached form with a stale token — wipes the admin session. The Mod then stopped on a bare die('<h1>Access Denied</h1>') (or the 403 die() in csrf_verify()), which renders as a blank/broken page outside the panel. Add a shared admin_deny() helper in GameEngine/Admin/csrf.php that renders a clean, self-contained, styled error page (with a "Return to Admin Panel" link) and a no-store header, then exits. Wire it into csrf_verify() and replace every bare "Access Denied" die() across the 42 admin Mods. Each Mod now loads csrf.php at the top so admin_deny() is available before its first access check. This is the presentation fix Shadow asked for ("we must receive an error not blank page"). The deeper root cause (admin and game sharing one PHP session) is left for a follow-up: giving the admin panel its own session cookie name. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
98 lines
4.0 KiB
PHP
98 lines
4.0 KiB
PHP
<?php
|
|
#################################################################################
|
|
## -= YOU MAY NOT REMOVE OR CHANGE THIS NOTICE =- ##
|
|
## --------------------------------------------------------------------------- ##
|
|
## Filename editAli.php ##
|
|
## Type BACKEND ##
|
|
## Developed by: Shadow (după model editUser) ##
|
|
## License: TravianZ Project ##
|
|
## Copyright: TravianZ (c) 2010-2025. All rights reserved. ##
|
|
#################################################################################
|
|
|
|
// #299: load CSRF helpers + admin_deny() before the access check below.
|
|
require_once(__DIR__ . '/../csrf.php');
|
|
if (!isset($_SESSION)) {
|
|
session_start();
|
|
}
|
|
if (empty($_SESSION['access']) || $_SESSION['access'] < 9) {
|
|
admin_deny('You must be signed in as an administrator to view this page. Your session may have expired — please return to the admin panel and sign in again.');
|
|
}
|
|
|
|
// Issue #139: this Mod is POSTed to directly, so it must verify the CSRF token
|
|
// itself (it does not go through admin.php's central csrf_verify()).
|
|
require_once(__DIR__ . '/../csrf.php');
|
|
csrf_verify();
|
|
|
|
include_once("../../config.php");
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Autoloader path - la fel ca în editUser.php
|
|
// ---------------------------------------------------------------------------
|
|
$autoprefix = '';
|
|
for ($i = 0; $i < 5; $i++) {
|
|
$autoprefix = str_repeat('../', $i);
|
|
if (file_exists($autoprefix . 'autoloader.php')) {
|
|
break;
|
|
}
|
|
}
|
|
include_once($autoprefix . "GameEngine/Database.php");
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Input
|
|
// ---------------------------------------------------------------------------
|
|
$admid = (int)($_POST['admid'] ?? 0);
|
|
$aid = (int)($_POST['aid'] ?? 0);
|
|
|
|
if ($aid <= 0 || $admid <= 0) {
|
|
header("Location: ../../../Admin/admin.php?p=alliance&aid=$aid&e=bad");
|
|
exit;
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Verificare admin - la fel ca editUser
|
|
// ---------------------------------------------------------------------------
|
|
$admin = $database->getUserArray($admid, 1);
|
|
if (!$admin || (int)$admin['access'] !== 9) {
|
|
admin_deny('You must be signed in as an administrator to view this page. Your session may have expired — please return to the admin panel and sign in again.');
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Câmpuri
|
|
// ---------------------------------------------------------------------------
|
|
$tag = $database->escape(substr(trim($_POST['tag'] ?? ''), 0, 8));
|
|
$name = $database->escape(substr(trim($_POST['name'] ?? ''), 0, 25));
|
|
$leader = (int)($_POST['leader'] ?? 0);
|
|
$max = (int)($_POST['max'] ?? 0);
|
|
$max = max(3, min(60, $max));
|
|
$notice = $database->escape($_POST['notice'] ?? '');
|
|
$desc = $database->escape($_POST['desc'] ?? '');
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Update
|
|
// ---------------------------------------------------------------------------
|
|
$database->query(
|
|
"UPDATE " . TB_PREFIX . "alidata SET
|
|
tag = '$tag',
|
|
name = '$name',
|
|
leader = $leader,
|
|
`max` = $max,
|
|
notice = '$notice',
|
|
`desc` = '$desc'
|
|
WHERE id = $aid"
|
|
);
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Log admin - aceeași structură ca editUser
|
|
// ---------------------------------------------------------------------------
|
|
$time = time();
|
|
$logText = "Edited alliance <a href='admin.php?p=alliance&aid=$aid'>$tag</a>";
|
|
$logEsc = $database->escape($logText);
|
|
|
|
$database->query(
|
|
"INSERT INTO " . TB_PREFIX . "admin_log (`id`, `user`, `log`, `time`) " .
|
|
"VALUES (0, '$admid', '$logEsc', $time)"
|
|
);
|
|
|
|
header("Location: ../../../Admin/admin.php?p=alliance&aid=$aid&edited=1");
|
|
exit;
|
|
?>
|