Files
3x-ui/frontend/src/test/routing-loopback-index.test.tsx
T
MHSanaei 982ab276e8 fix(frontend): map routing row actions through the rule's real index
The routing table hides balancer-loopback rules (`_bl_*`) but keeps each
visible row's original index in `key`, then handed antd's positional row
index straight to edit/delete/toggle/move/drag — all of which mutate the
full, unfiltered routing.rules array. Once a hidden loopback rule precedes a
visible one (e.g. a balancer whose fallback is another balancer, plus any
rule added afterwards), the positional index no longer matches the array
index, so deleting or editing a rule silently hit the wrong one — including
destroying the loopback rule that keeps the balancer alive.

Add originalRuleIndex to translate a positional row index back through the
row's `key`, and route every mutating handler (openEdit, confirmDelete,
toggleRule, moveUp/moveDown, drag) through it. When no loopback rows are
hidden the mapping is the identity, so ordinary configs are unaffected.
2026-07-15 05:42:16 +02:00

56 lines
1.9 KiB
TypeScript

import { describe, it, expect, vi } from 'vitest';
import { fireEvent, screen } from '@testing-library/react';
import { QueryClient, QueryClientProvider } from '@tanstack/react-query';
import RoutingTab from '@/pages/xray/routing/RoutingTab';
import type { XraySettingsValue } from '@/hooks/useXraySetting';
import { renderWithProviders } from './test-utils';
function settingsWithHiddenLoopback(): XraySettingsValue {
return {
routing: {
rules: [
{ type: 'field', outboundTag: 'a', enabled: true },
{ type: 'field', inboundTag: ['_bl_bal1'], outboundTag: 'b', enabled: true },
{ type: 'field', outboundTag: 'c', enabled: true },
],
},
} as unknown as XraySettingsValue;
}
describe('RoutingTab hidden-loopback index mapping', () => {
it('toggles the visible rule, not the hidden loopback rule that precedes it', () => {
const setTemplateSettings = vi.fn();
const initial = settingsWithHiddenLoopback();
const queryClient = new QueryClient({ defaultOptions: { queries: { retry: false } } });
renderWithProviders(
<QueryClientProvider client={queryClient}>
<RoutingTab
templateSettings={initial}
setTemplateSettings={setTemplateSettings}
inboundTags={[]}
clientReverseTags={[]}
isMobile={false}
/>
</QueryClientProvider>,
);
fireEvent.click(screen.getByRole('tab', { name: /Routing Rules/ }));
const switches = document.querySelectorAll('.routing-table .ant-switch');
expect(switches.length).toBe(2);
fireEvent.click(switches[1]);
expect(setTemplateSettings).toHaveBeenCalledTimes(1);
const updater = setTemplateSettings.mock.calls[0][0] as (prev: XraySettingsValue) => XraySettingsValue;
const next = updater(initial);
const rules = (next.routing as { rules: Array<{ enabled?: boolean }> }).rules;
expect(rules[2].enabled).toBe(false);
expect(rules[1].enabled).toBe(true);
});
});