mirror of
https://github.com/MHSanaei/3x-ui.git
synced 2026-07-16 09:36:07 +00:00
MHSanaei
06cd75abe0
The web/sub same-port check compared the two listen addresses as raw strings, so
binding both on all interfaces with different spellings (webListen 0.0.0.0 vs an
empty subListen) slipped past validation and only failed at startup with an
opaque bind error. Treat any wildcard listen ('', 0.0.0.0, ::) as overlapping so
the clash is reported up front, while still allowing two distinct specific
addresses to share a port.
44 lines
1.3 KiB
Go
44 lines
1.3 KiB
Go
package entity
|
|
|
|
import "testing"
|
|
|
|
func TestCheckValidSmtpFrom(t *testing.T) {
|
|
base := func() *AllSetting {
|
|
return &AllSetting{WebPort: 2053, SubPort: 2096}
|
|
}
|
|
|
|
for _, v := range []string{"", "panel@example.com"} {
|
|
s := base()
|
|
s.SmtpFrom = v
|
|
if err := s.CheckValid(); err != nil {
|
|
t.Errorf("CheckValid with smtpFrom=%q: unexpected error %v", v, err)
|
|
}
|
|
}
|
|
|
|
for _, v := range []string{
|
|
"not-an-address",
|
|
"panel@example.com\r\nBcc: evil@example.com",
|
|
"a@b\nSubject: injected",
|
|
} {
|
|
s := base()
|
|
s.SmtpFrom = v
|
|
if err := s.CheckValid(); err == nil {
|
|
t.Errorf("CheckValid with smtpFrom=%q: want error, got nil", v)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestCheckValidWildcardListenPortConflict(t *testing.T) {
|
|
// Same port, both bind all interfaces but spelled differently -> conflict.
|
|
s := &AllSetting{WebPort: 2053, SubPort: 2053, WebListen: "0.0.0.0", SubListen: ""}
|
|
if err := s.CheckValid(); err == nil {
|
|
t.Error("CheckValid must reject the same port bound on 0.0.0.0 and \"\" (both wildcard)")
|
|
}
|
|
|
|
// Same port on two distinct specific addresses can coexist and must be allowed.
|
|
ok := &AllSetting{WebPort: 2053, SubPort: 2053, WebListen: "127.0.0.1", SubListen: "192.168.1.1"}
|
|
if err := ok.CheckValid(); err != nil {
|
|
t.Errorf("distinct specific listens on the same port should be allowed: %v", err)
|
|
}
|
|
}
|