fix(web): keep extension market navigable at quota (#2390)

Co-authored-by: dadachann <185672915+dadachann@users.noreply.github.com>
This commit is contained in:
Hyu
2026-08-03 20:10:46 +08:00
committed by GitHub
parent f0b2c103c1
commit 6bad7bcffc
5 changed files with 22 additions and 27 deletions
@@ -543,33 +543,19 @@ function NavItems({
if (config.id === 'add-extension' && !canManageResources) {
return null;
}
const quota =
config.id === 'add-extension'
? quotaStatus.extensions
: UNLIMITED_QUOTA;
// Non-entity entries (e.g. monitoring and the extension market) render as plain links.
return (
<SidebarMenuItem key={config.id}>
<WorkspaceQuotaTooltip
quota={quota}
resource={config.name}
side="right"
<SidebarMenuButton
isActive={selectedChild?.id === config.id}
onClick={() => onChildClick(config)}
tooltip={config.name}
>
<SidebarMenuButton
isActive={selectedChild?.id === config.id}
onClick={() => {
if (!quota.disabled) onChildClick(config);
}}
disabled={quota.disabled}
aria-disabled={quota.disabled}
tooltip={quota.disabled ? undefined : config.name}
>
{config.icon}
<span className="cursor-pointer select-none">
{config.name}
</span>
</SidebarMenuButton>
</WorkspaceQuotaTooltip>
{config.icon}
<span className="cursor-pointer select-none">
{config.name}
</span>
</SidebarMenuButton>
</SidebarMenuItem>
);
}
@@ -39,7 +39,7 @@ export function WorkspaceQuotaTooltip({
{children}
</span>
</TooltipTrigger>
<TooltipContent side={side} className="max-w-72 text-center">
<TooltipContent side={side} className="max-w-72 text-left">
{message}
</TooltipContent>
</Tooltip>
@@ -399,7 +399,7 @@ export default function PluginMarketCardComponent({
<TooltipProvider delayDuration={200}>
<Tooltip>
<TooltipTrigger asChild>{cardContent}</TooltipTrigger>
<TooltipContent side="top" className="max-w-72 text-center">
<TooltipContent side="top" className="max-w-72 text-left">
{installDisabledTooltip}
</TooltipContent>
</Tooltip>
+3 -2
View File
@@ -119,7 +119,7 @@ test('quota-reached create actions are disabled and explain the current limit',
await expect(botCreate).toBeDisabled();
await expect(pipelineCreate).toBeDisabled();
await expect(knowledgeCreate).toBeDisabled();
await expect(addExtension).toBeDisabled();
await expect(addExtension).toBeEnabled();
const botQuotaTrigger = botCreate.locator('..');
await botQuotaTrigger.hover();
@@ -136,7 +136,8 @@ test('quota-reached create actions are disabled and explain the current limit',
),
).toBeVisible();
await page.goto('/home/add-extension');
await addExtension.click();
await expect(page).toHaveURL(/\/home\/add-extension$/);
const manualAdd = page.getByRole('button', { name: 'Manual Add' });
await expect(manualAdd).toBeDisabled();
await manualAdd.locator('..').hover();
@@ -63,7 +63,13 @@ test('sidebar quota-disables create controls and renders a tooltip', () => {
assert.match(tooltip, /limitation\.createDisabledTooltip/);
assert.match(tooltip, /limitation\.quotaLoadingTooltip/);
assert.match(tooltip, /tabIndex=\{0\}/);
assert.match(tooltip, /max-w-72 text-left/);
assert.doesNotMatch(tooltip, /text-center/);
assert.match(source, /config\.id === 'add-extension'/);
assert.doesNotMatch(
source,
/config\.id === 'add-extension'\s*\?\s*quotaStatus\.extensions/,
);
});
test('add-extension page disables all install entry points at the quota', () => {
@@ -80,6 +86,8 @@ test('add-extension page disables all install entry points at the quota', () =>
assert.match(card, /installDisabled/);
assert.match(card, /disabled=\{installDisabled\}/);
assert.match(card, /TooltipContent/);
assert.match(card, /max-w-72 text-left/);
assert.doesNotMatch(card, /max-w-72 text-center/);
assert.match(recommendations, /installDisabled=\{installDisabled\}/);
assert.match(
recommendations,