mirror of
https://github.com/langbot-app/LangBot.git
synced 2026-06-02 12:05:54 +00:00
Fix code review issues
- Use specific exception types instead of bare except - Fix misleading comments about directory levels - Remove redundant existence check before makedirs with exist_ok=True - Use context manager for file opening to ensure proper cleanup Co-authored-by: RockChinQ <45992437+RockChinQ@users.noreply.github.com>
This commit is contained in:
@@ -86,10 +86,7 @@ def main():
|
||||
# Set up the working directory
|
||||
# When installed as a package, we need to handle the working directory differently
|
||||
# We'll create data directory in current working directory if not exists
|
||||
if not os.path.exists('data'):
|
||||
print('Creating data directory in current working directory...')
|
||||
print('在当前工作目录创建 data 目录...')
|
||||
os.makedirs('data', exist_ok=True)
|
||||
os.makedirs('data', exist_ok=True)
|
||||
|
||||
loop = asyncio.new_event_loop()
|
||||
|
||||
|
||||
@@ -82,7 +82,8 @@ class PipelineService:
|
||||
pipeline_data['is_default'] = default
|
||||
|
||||
template_path = path_utils.get_resource_path('templates/default-pipeline-config.json')
|
||||
pipeline_data['config'] = json.load(open(template_path, 'r', encoding='utf-8'))
|
||||
with open(template_path, 'r', encoding='utf-8') as f:
|
||||
pipeline_data['config'] = json.load(f)
|
||||
|
||||
await self.ap.persistence_mgr.execute_async(
|
||||
sqlalchemy.insert(persistence_pipeline.LegacyPipeline).values(**pipeline_data)
|
||||
|
||||
@@ -26,7 +26,8 @@ def _check_if_source_install() -> bool:
|
||||
if 'LangBot/main.py' in content:
|
||||
_is_source_install = True
|
||||
return True
|
||||
except Exception:
|
||||
except (IOError, OSError, UnicodeDecodeError):
|
||||
# If we can't read the file, assume not a source install
|
||||
pass
|
||||
|
||||
_is_source_install = False
|
||||
@@ -51,7 +52,7 @@ def get_frontend_path() -> str:
|
||||
|
||||
# Third, find it relative to the package installation
|
||||
# Get the directory where this file is located
|
||||
# paths.py is in pkg/utils/, so go up 3 levels to get to the package root
|
||||
# paths.py is in pkg/utils/, so parent.parent goes up to pkg/, then parent again goes up to the package root
|
||||
pkg_dir = Path(__file__).parent.parent.parent
|
||||
frontend_path = pkg_dir / 'web' / 'out'
|
||||
if frontend_path.exists():
|
||||
@@ -81,7 +82,7 @@ def get_resource_path(resource: str) -> str:
|
||||
|
||||
# Third, find it relative to package directory
|
||||
# Get the directory where this file is located
|
||||
# paths.py is in pkg/utils/, so go up 3 levels to get to the package root
|
||||
# paths.py is in pkg/utils/, so parent.parent goes up to pkg/, then parent again goes up to the package root
|
||||
pkg_dir = Path(__file__).parent.parent.parent
|
||||
resource_path = pkg_dir / resource
|
||||
if resource_path.exists():
|
||||
|
||||
Reference in New Issue
Block a user