xinyin025/LangBot
1
0
Fork 0
mirror of https://github.com/langbot-app/LangBot.git synced 2026-06-08 14:56:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix code review issues

Browse Source 
- Use specific exception types instead of bare except
- Fix misleading comments about directory levels
- Remove redundant existence check before makedirs with exist_ok=True
- Use context manager for file opening to ensure proper cleanup

Co-authored-by: RockChinQ <45992437+RockChinQ@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-11-07 14:06:49 +00:00
parent 4e86e1c93d
commit f784bad08b
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/utils/paths.py
View File

@@ -26,7 +26,8 @@ def _check_if_source_install() -> bool:
if 'LangBot/main.py' in content:
_is_source_install = True
return True
except Exception:
except (IOError, OSError, UnicodeDecodeError):
# If we can't read the file, assume not a source install
pass
_is_source_install = False
@@ -51,7 +52,7 @@ def get_frontend_path() -> str:
# Third, find it relative to the package installation
# Get the directory where this file is located
# paths.py is in pkg/utils/, so go up 3 levels to get to the package root
# paths.py is in pkg/utils/, so parent.parent goes up to pkg/, then parent again goes up to the package root
pkg_dir = Path(__file__).parent.parent.parent
frontend_path = pkg_dir / 'web' / 'out'
if frontend_path.exists():
@@ -81,7 +82,7 @@ def get_resource_path(resource: str) -> str:
# Third, find it relative to package directory
# Get the directory where this file is located
# paths.py is in pkg/utils/, so go up 3 levels to get to the package root
# paths.py is in pkg/utils/, so parent.parent goes up to pkg/, then parent again goes up to the package root
pkg_dir = Path(__file__).parent.parent.parent
resource_path = pkg_dir / resource
if resource_path.exists():